Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: ibc-go 7.3.0 is not used #1184

Merged
merged 11 commits into from
Sep 26, 2023
Merged

Problem: ibc-go 7.3.0 is not used #1184

merged 11 commits into from
Sep 26, 2023

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Sep 25, 2023 •
edited
Loading

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

For more info

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

yihuang
yihuang reviewed Sep 25, 2023
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@mmsqe mmsqe marked this pull request as ready for review September 25, 2023 08:43
@mmsqe mmsqe requested a review from a team as a code owner September 25, 2023 08:43
@mmsqe mmsqe requested review from devashishdxt and leejw51crypto and removed request for a team September 25, 2023 08:43
@mmsqe mmsqe enabled auto-merge September 25, 2023 08:46
@codecov
Copy link

codecov bot commented Sep 25, 2023 •
edited
Loading

Codecov Report

Merging #1184 (5f3329d) into main (3313f54) will increase coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1184      +/-   ##
==========================================
+ Coverage   37.61%   37.62%   +0.01%     
==========================================
  Files         114      114              
  Lines       10077    10073       -4     
==========================================
  Hits         3790     3790              
+ Misses       5907     5903       -4     
  Partials      380      380
Files Changed Coverage Δ
x/cronos/keeper/precompiles/bank.go 2.50% <0.00%> (+0.08%) ⬆️

@mmsqe mmsqe added this pull request to the merge queue Sep 25, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 25, 2023
@mmsqe mmsqe added this pull request to the merge queue Sep 26, 2023
Merged via the queue into crypto-org-chain:main with commit f11271b Sep 26, 2023
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calvinaco calvinaco calvinaco left review comments

@yihuang yihuang yihuang approved these changes

@devashishdxt devashishdxt Awaiting requested review from devashishdxt devashishdxt is a code owner automatically assigned from crypto-org-chain/cronos-dev

@leejw51crypto leejw51crypto Awaiting requested review from leejw51crypto leejw51crypto is a code owner automatically assigned from crypto-org-chain/cronos-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmsqe @yihuang @calvinaco